AnandInguva commented on code in PR #28385:
URL: https://github.com/apache/beam/pull/28385#discussion_r1334681141


##########
sdks/python/setup.py:
##########
@@ -187,7 +194,29 @@ def get_portability_package_data():
   # In order to find the tree of proto packages, the directory
   # structure must exist before the call to setuptools.find_packages()
   # executes below.
+  # while True: print(os.listdir())
   generate_protos_first()
+
+  # generate cythonize extensions only if we are building a wheel or
+  # building an extension or running in editable mode.

Review Comment:
   -e is a editable installation.  During editable installations, the pep 517 
creates an editable wheel.  There is no `editable_wheel` mode. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to