liferoad commented on code in PR #28595:
URL: https://github.com/apache/beam/pull/28595#discussion_r1334773857
##########
sdks/python/apache_beam/yaml/yaml_io_test.py:
##########
@@ -50,14 +63,17 @@ def __call__(
class FakeWriteToPubSub:
- def __init__(self, topic, messages, timestamp_attribute=None):
+ def __init__(
+ self, topic, messages, id_attribute=None, timestamp_attribute=None):
self._topic = topic
self._messages = messages
+ self._id_attribute = id_attribute
self._timestamp_attribute = timestamp_attribute
- def __call__(self, topic, *, with_attributes, timestamp_attribute):
+ def __call__(self, topic, *, with_attributes, id_label, timestamp_attribute):
Review Comment:
id_attribute?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
