m-trieu commented on code in PR #28537: URL: https://github.com/apache/beam/pull/28537#discussion_r1336628269
########## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/KeyCommitTooLargeException.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.dataflow.worker.streaming; + +import org.apache.beam.runners.dataflow.worker.windmill.Windmill; + +public class KeyCommitTooLargeException extends Exception { Review Comment: I think breaking them out improves readability as it shrinks the class size and helps us individually test the different component's interfaces. Internally we have recommendations. go/java-practices/class-structure#length They are all referenced by StreamingDataflowWorker so they have to be public unless we move StreamingDataflowWorker into this package. We could move most of the logic into this package, and just expose main in the current StreamingDataflowWorker.java (probably in a different cl since that file is quite large in surface area) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
