twang126 commented on code in PR #28513:
URL: https://github.com/apache/beam/pull/28513#discussion_r1340539982
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -2027,6 +2034,10 @@ private void updateVMMetrics() {
private void updateThreadMetrics() {
timeAtMaxActiveThreads.getAndReset();
timeAtMaxActiveThreads.addValue(workUnitExecutor.allThreadsActiveTime());
+ activeThreads.getAndReset();
+ activeThreads.addValue(workUnitExecutor.activeCount());
+ maxActiveThreads.getAndReset();
+ maxActiveThreads.addValue(chooseMaximumNumberOfThreads());
Review Comment:
Yeah, it's exactly in the same spirit as
javaHarnessUsedMemory/javaHarnessMaxMemory.
As for the long vs int counter type, I'm not familiar with how counters are
reported, but I was somehow under the impression that with the GetAndReset, the
value of this counter would never approach the int max limit? In that way, it's
almost acting as a gauge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
