amaliujia commented on a change in pull request #12488:
URL: https://github.com/apache/beam/pull/12488#discussion_r467330787
##########
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/EvaluationContext.java
##########
@@ -183,6 +188,15 @@ public void initialize(
committedResult.getUnprocessedInputs().orElse(null),
committedResult.getOutputs(),
result.getWatermarkHold());
+
+ // Callback and requested bundle finalizations
+ for (InMemoryBundleFinalizer.Finalization finalization :
result.getBundleFinalizations()) {
+ try {
+ finalization.getCallback().onBundleSuccess();
+ } catch (Exception e) {
Review comment:
Is is possible to make this Exception more specific? Or that does not
add more values?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]