nancyxu123 commented on code in PR #28751:
URL: https://github.com/apache/beam/pull/28751#discussion_r1342958482
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/SpannerChangeStreamErrorTest.java:
##########
@@ -311,11 +351,9 @@ public void testInvalidRecordReceived() {
pipeline.run().waitUntilFinish();
} finally {
thrown.expect(PipelineExecutionException.class);
- // DatabaseClient.getDialect returns "DEADLINE_EXCEEDED: Operation did
not complete in the "
- // given time" even though we mocked it out.
thrown.expectMessage("Field not found");
assertThat(
- mockSpannerService.countRequestsOfType(ExecuteSqlRequest.class),
Matchers.equalTo(0));
+ mockSpannerService.countRequestsOfType(ExecuteSqlRequest.class),
Matchers.greaterThan(0));
Review Comment:
I think the behavior change is fine, since previously this test was
disabled, so I'm not exactly sure which part was broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
