ahmedabu98 commented on code in PR #28591: URL: https://github.com/apache/beam/pull/28591#discussion_r1342978484
########## website/www/site/content/en/documentation/io/built-in/google-bigquery.md: ########## @@ -901,9 +901,9 @@ specify the number of streams, and you can’t specify the triggering frequency. Auto sharding is not applicable for `STORAGE_API_AT_LEAST_ONCE`. -When using `STORAGE_API_AT_LEAST_ONCE`, the PCollection returned by -[`WriteResult.getFailedInserts`](https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/io/gcp/bigquery/WriteResult.html#getFailedInserts--) -will not contain the failed rows. If there are data validation errors, the +When using `STORAGE_API_AT_LEAST_ONCE`, the `PCollection` returned by +[`WriteResult.getFailedStorageApiInserts`](https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/io/gcp/bigquery/WriteResult.html#getFailedStorageApiInserts--) +will contain the rows that failed to be written by the Storage Write API. If there are data validation errors, the Review Comment: ```suggestion will contain the rows that failed to be written to the Storage Write API sink. If there are data validation errors, the ``` ########## website/www/site/content/en/documentation/io/built-in/google-bigquery.md: ########## @@ -883,9 +883,9 @@ explicitly enable this using [`withAutoSharding`](https://beam.apache.org/releas ***Note:*** Auto sharding with `STORAGE_WRITE_API` is supported on Dataflow's legacy runner, but **not** on Runner V2 {{< /paragraph >}} -When using `STORAGE_WRITE_API`, the PCollection returned by -[`WriteResult.getFailedInserts`](https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/io/gcp/bigquery/WriteResult.html#getFailedInserts--) -will not contain the failed rows. If there are data validation errors, the +When using `STORAGE_WRITE_API`, the `PCollection` returned by +[`WriteResult.getFailedStorageApiInserts`](https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/io/gcp/bigquery/WriteResult.html#getFailedStorageApiInserts--) +will contain the rows that failed to be written by the Storage Write API. If there are data validation errors, the Review Comment: ```suggestion will contain the rows that failed to be written to the Storage Write API sink. If there are data validation errors, the ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
