johnjcasey commented on code in PR #28397:
URL: https://github.com/apache/beam/pull/28397#discussion_r1342990424
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/BigqueryClient.java:
##########
@@ -292,6 +292,21 @@ private QueryResponse getTypedTableRows(QueryResponse
response) {
public List<TableRow> queryUnflattened(
String query, String projectId, boolean typed, boolean useStandardSql)
throws IOException, InterruptedException {
+ return queryUnflattened(query, projectId, typed, useStandardSql, null);
+ }
+
+ /**
+ * Performs a query without flattening results. May choose a location to
perform this operation
Review Comment:
What does "choose a location" mean?
##########
sdks/java/io/google-cloud-platform/build.gradle:
##########
@@ -244,6 +242,45 @@ task integrationTestKms(type: Test) {
}
}
+/*
+ Integration tests for BigQueryIO that run on BigQuery's early rollout region
(us-east7)
+ with the intended purpose of catching breaking changes from new BigQuery
releases.
+ If these tests fail here but not in `Java_GCP_IO_Direct`, there may be a new
BigQuery change
+ that is breaking the connector.
Review Comment:
Can we add some information here to clarify which team we should contact in
case of this failure mode?
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOStorageReadTableRowIT.java:
##########
@@ -52,7 +52,13 @@
@RunWith(JUnit4.class)
public class BigQueryIOStorageReadTableRowIT {
- private static final String DATASET_ID = "big_query_import_export";
+ private static final String DATASET_ID =
+ TestPipeline.testingPipelineOptions()
+ .as(TestBigQueryOptions.class)
+ .getBigQueryLocation()
+ .equals("us-east7")
Review Comment:
We should probably change "us-east7" to a constant somewhere, instead of
having a magic string. Something like "BIGQUERY_EARLY_ROLLOUT_REGION" perhaps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
