AnandInguva commented on code in PR #28385:
URL: https://github.com/apache/beam/pull/28385#discussion_r1344311234
##########
sdks/python/apache_beam/runners/portability/stager.py:
##########
@@ -771,13 +772,26 @@ def _build_setup_package(setup_file, # type: str
try:
os.chdir(os.path.dirname(setup_file))
if build_setup_args is None:
- build_setup_args = [
- Stager._get_python_executable(),
- os.path.basename(setup_file),
- 'sdist',
- '--dist-dir',
- temp_dir
- ]
+ # if build is installed in the user env, use it to
+ # build the sdist else fallback to legacy setup.py sdist call.
+ if importlib.util.find_spec('build'):
Review Comment:
The new process calls the old process under the hood in a way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
