tvalentyn commented on code in PR #28780:
URL: https://github.com/apache/beam/pull/28780#discussion_r1344717329
##########
sdks/python/apache_beam/testing/analyzers/perf_analysis.py:
##########
@@ -84,6 +85,20 @@ def run_change_point_analysis(params, test_name,
big_query_metrics_fetcher):
if not change_point_index:
logging.info("Change point is not detected for the test %s" % test_name)
return False
+ # Remove the change points that are at the edges of the data.
+ # https://github.com/apache/beam/issues/28757
+ # Remove this workaround once we have a good solution to deal
+ # with the edge change points.
+ if is_edge_change_point(change_point_index,
Review Comment:
I would move this logic into find_latest_change_point_index since there are
other considerations in that function to filter out noise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
