Abacn commented on PR #27256:
URL: https://github.com/apache/beam/pull/27256#issuecomment-1745796802

   > This PR results in a command line arg of `--host`, which is a little 
generic and has the risk of conflicting with other `PipelineOptions` classes 
(not to mention non-PipelineOptions arguments). Can we revisit to rename to 
something more specific like `firestoreHost` (which corresponds with the 
already-existing `firestoreDb`)
   > 
   > 
   > 
   > cc @Abacn 
   
   Thanks, this sounds totally reasonable and I should have noticed this 
honestly. Would you mind drafting a PR for it. This flag currently is used for 
testing purpose so it should be fine


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to