AnandInguva commented on code in PR #28671: URL: https://github.com/apache/beam/pull/28671#discussion_r1346231288
########## sdks/python/apache_beam/testing/analyzers/perf_analysis.py: ########## @@ -169,12 +182,11 @@ def run(config_file_path: Optional[str] = None) -> None: tests_config: Dict[str, Dict[str, Any]] = read_test_config(config_file_path) - big_query_metrics_fetcher = BigQueryMetricsFetcher() - for test_name, params in tests_config.items(): + for test_id, params in tests_config.items(): Review Comment: Yes, passing metrics as list will be implemented in a different PR. I will tag you there once it is ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
