je-ik commented on issue #28554:
URL: https://github.com/apache/beam/issues/28554#issuecomment-1747399873
There are two problems:
a) there can be other reasons why there are watermark holds besides stable
input bufferring, so skipping the checks would hide those as well
b) draining pipeline first updates watermark to infinity, which (as
documented) would result in incorrect output if the pipeline is later resumed
from the final savepoint (it would move watermark bafk in time, which is
correctness bug). Draining is meant only for cases when the pipeline will not
be resumed later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
