brucearctor commented on code in PR #28865:
URL: https://github.com/apache/beam/pull/28865#discussion_r1349230087
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaReadSchemaTransformConfiguration.java:
##########
@@ -39,7 +39,7 @@ public abstract class KafkaReadSchemaTransformConfiguration {
public static final Set<String> VALID_START_OFFSET_VALUES =
Sets.newHashSet("earliest", "latest");
- public static final String VALID_FORMATS_STR = "AVRO,JSON";
+ public static final String VALID_FORMATS_STR = "raw,avro,json";
public static final Set<String> VALID_DATA_FORMATS =
Sets.newHashSet(VALID_FORMATS_STR.split(","));
Review Comment:
Wanting to look more at this:
* Is there a reason for the convention of UPPERCASE, vs lower?
* Why use a string that we need to then split on the subsequent line,
instead of adding to a new set directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
