Abacn commented on code in PR #28875:
URL: https://github.com/apache/beam/pull/28875#discussion_r1349244399


##########
sdks/java/testing/jpms-tests/build.gradle:
##########
@@ -21,7 +21,14 @@ import groovy.json.JsonOutput
 plugins {
   id 'org.apache.beam.module'
 }
-javaVersion="1.11"
+
+// overwrite javaVersion before applyJavaNature
+if (project.hasProperty("compileAndRunTestsWithJava17")) {
+  javaVersion = '1.17'
+} else {
+  javaVersion = '1.11'
+}
+
 applyJavaNature(
   exportJavadoc: false,

Review Comment:
   Note that jpms-tests is a test module that does not publish to maven, so 
this PR won't change RC



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to