chamikaramj commented on code in PR #28783:
URL: https://github.com/apache/beam/pull/28783#discussion_r1349814718
##########
sdks/java/transform-service/src/main/java/org/apache/beam/sdk/transformservice/ExpansionService.java:
##########
@@ -40,6 +47,12 @@ public class ExpansionService extends
ExpansionServiceGrpc.ExpansionServiceImplB
final List<Endpoints.ApiServiceDescriptor> endpoints;
+ private boolean checkedAllServices = false;
+
+ private static final long SERVICE_CHECK_TIMEOUT = 60000;
Review Comment:
Done.
##########
sdks/java/transform-service/launcher/src/main/java/org/apache/beam/sdk/transformservice/launcher/TransformServiceLauncher.java:
##########
@@ -124,10 +128,84 @@ private TransformServiceLauncher(@Nullable String
projectName, int port) throws
}
}
+ // Setting up the dependencies directory.
+ File dependenciesDir = Paths.get(tmpDir, "dependencies_dir").toFile();
+ Path updatedRequirementsFilePath = Paths.get(dependenciesDir.toString(),
"requirements.txt");
+ LOG.info(
+ "Creating a temporary directory for storing dependencies: "
Review Comment:
Done.
##########
sdks/java/transform-service/launcher/src/test/java/org/apache/beam/sdk/transformservice/launcher/TransformServiceLauncherTest.java:
##########
@@ -0,0 +1,185 @@
+/*
Review Comment:
Thanks. Added the projects to the PreCommit task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
