mxm commented on a change in pull request #12499:
URL: https://github.com/apache/beam/pull/12499#discussion_r467997322
##########
File path: .test-infra/jenkins/job_LoadTests_ParDo_Flink_Python.groovy
##########
@@ -161,12 +164,13 @@ def streamingScenarios = { datasetName ->
test : 'apache_beam.testing.load_tests.pardo_test',
runner : CommonTestProperties.Runner.PORTABLE,
pipelineOptions: [
- job_name : 'load-tests-python-flink-streaming-pardo-5-' +
now,
+ job_name : 'load-tests-python-flink-streaming-pardo-1-' +
now,
Review comment:
> @mxm Do you think it is possible to adjust those parameters so that
`pardo-5` can become `pardo-1` and `pardo-6` can become `pardo-2`, `pardo-3` or
`pardo-4`? The main advantage of this solution is that we wouldn't have to
modify dashboards at all. The old version would just work.
That was the original idea in this PR which you I understood you didn't
like. pardo_5 became pardo_1. As for pardo_6, that's not possible because it
measures the checkpoint duration and should be a separate panel.
> If not, then I'm fine with adding new charts (I suppose you'd meant
"chart", "dashboard" is a different kind of thing) and removing the selector
for batch/streaming.
Yes, I meant panel, corrected above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
