m-trieu commented on PR #28835: URL: https://github.com/apache/beam/pull/28835#issuecomment-1756465034
still working on changes will ping when done @scwhittle Changes are: - Also adding a unit test for `StreamingEngineClient`. - Instead of having raw threads in `StreamingEngineClient` I am opting for using 3 `ExecutorService`(s) that are single threaded to handle the `GetWorkerMetadata` and budget refreshes 1. `ExecutorService` for starting the `GetWorkerMetadataStream` 2. `ScheduledExecutorService` for recurring budget refreshes 3. `ExecutorService` that has a runnable listening to `SynchronizedQueue`, for triggered budget refreshes. - triggered when work is completed - triggered when WorkerMetadata is consumed Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
