tvalentyn commented on a change in pull request #12239: URL: https://github.com/apache/beam/pull/12239#discussion_r468301103
########## File path: sdks/python/test-suites/gradle.properties ########## @@ -0,0 +1,38 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################ + +# Following properties define which Python versions be used when the tests running. +# Versions must be indicated major and minor versions connected with period. +# And if you want to use multiple versions, concat them with comma and no whitespace. + +# dataflow test-suites +dataflow_precommit_it_task_py_versions=2.7,3.7 +dataflow_mongodbio_it_task_py_versions=3.5 Review comment: I don't think we have a dataflow MongoDB suite - I only see a direct runner suite. ########## File path: sdks/python/test-suites/gradle.properties ########## @@ -0,0 +1,38 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################ + +# Following properties define which Python versions be used when the tests running. +# Versions must be indicated major and minor versions connected with period. +# And if you want to use multiple versions, concat them with comma and no whitespace. + +# dataflow test-suites +dataflow_precommit_it_task_py_versions=2.7,3.7 +dataflow_mongodbio_it_task_py_versions=3.5 +dataflow_chicago_taxi_example_task_py_versions=2.7 + +# direct test-suites +hdfs_integration_test_task_py_versions=2.7,3.8 +direct_mongodbio_it_task_py_versions=2.7,3.5 +direct_runner_it_task_py_versions=2.7 + +# portable test-suites +cross_language_task_py_versions=2.7 Review comment: one more comment: it looks like portable test suite configuration currently does not have any effect, because the tasks from portable/build.gradle are not referenced in any groovy files or top-level tasks. let's not add these configs and not add `/portable/build.gradle` in this change, and make those changes once we are ready to switch to using tasks from `portable/build.gradle`. In current form, configs in `portable` section make an illusion that they control the versions of suites being used, but they currently don't. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
