robertwb commented on code in PR #28946:
URL: https://github.com/apache/beam/pull/28946#discussion_r1362363985
##########
sdks/python/apache_beam/runners/common.py:
##########
@@ -1928,6 +1928,10 @@ def validate_transform(transform_id):
"Incompatible input coder %s and output coder %s for transform %s"
%
(transform_id, input_coder, output_coder))
+ if transform_proto.spec.urn == common_urns.primitives.ASSIGN_WINDOWS.urn:
Review Comment:
Let's validate `common_urns.primitives.PAR_DO.urn` as well.
##########
sdks/python/apache_beam/runners/common.py:
##########
@@ -1928,6 +1928,10 @@ def validate_transform(transform_id):
"Incompatible input coder %s and output coder %s for transform %s"
%
(transform_id, input_coder, output_coder))
+ if transform_proto.spec.urn == common_urns.primitives.ASSIGN_WINDOWS.urn:
+ if not transform_proto.inputs:
+ raise ValueError("Unexpected number of inputs: %s" % transform_proto)
Review Comment:
Maybe say "Missing inputs?"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
