robertwb commented on code in PR #29014:
URL: https://github.com/apache/beam/pull/29014#discussion_r1364484244
##########
sdks/python/apache_beam/yaml/main.py:
##########
@@ -43,8 +44,8 @@ def _pipeline_spec_from_args(known_args):
raise ValueError(
"Exactly one of pipeline_spec or pipeline_spec_file must be set.")
elif known_args.pipeline_spec_file:
- with open(known_args.pipeline_spec_file) as fin:
Review Comment:
I think we still want to use the with syntax to make sure it gets closed
properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
