twang126 commented on code in PR #29041:
URL: https://github.com/apache/beam/pull/29041#discussion_r1364516030
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -1715,6 +1731,14 @@ private void updateThreadMetrics() {
activeThreads.addValue(workUnitExecutor.activeCount());
totalAllocatedThreads.getAndReset();
totalAllocatedThreads.addValue(chooseMaximumNumberOfThreads());
+ outstandingBytes.getAndReset();
+ outstandingBytes.addValue(workUnitExecutor.bytesOutstanding());
+ maxOutstandingBytes.getAndReset();
+ maxOutstandingBytes.addValue(workUnitExecutor.maximumBytesOutstanding());
+ outstandingBundles.getAndReset();
+ outstandingBundles.addValue(workUnitExecutor.elementsOutstanding());
Review Comment:
a little unclear here that bundles are also referred to as elements. Is this
supposed to be the case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
