scwhittle commented on code in PR #28755:
URL: https://github.com/apache/beam/pull/28755#discussion_r1365860715
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/streaming/sideinput/SideInputStateFetcherTest.java:
##########
@@ -312,9 +349,9 @@ private Windmill.GlobalData buildGlobalDataResponse(
return builder.build();
}
- private Windmill.GlobalDataRequest buildGlobalDataRequest(String tag,
ByteString version) {
+ private Windmill.GlobalDataRequest buildGlobalDataRequest(String tag) {
Review Comment:
seems like you removed version because we were always setting it to
ByteString.EMPTY when calling this. IT might be good to have a test where we
set a different version and verify it is plumbed as expected.
I believe the version is tied to the encoded window so this could reflect
that all the tests use a global window. Having a test with different interval
windows and verifying they are cached separately would be nice (could do in
separate PR if you'd rather since this isn't a regression in test coverage).
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/sideinput/SideInput.java:
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.dataflow.worker.streaming.sideinput;
+
+import com.google.auto.value.AutoValue;
+import java.util.Optional;
+import javax.annotation.Nullable;
+
+/**
+ * Entry in the side input cache that stores the value (null if not ready),
and the encoded size of
Review Comment:
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
