damccorm commented on code in PR #28918:
URL: https://github.com/apache/beam/pull/28918#discussion_r1365879939
##########
sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/jvmverification/JvmVerification.java:
##########
@@ -39,6 +40,7 @@ public class JvmVerification {
versionMapping.put("0034", v1_8);
versionMapping.put("0037", v11);
versionMapping.put("003d", v17);
+ versionMapping.put("0041", v21);
Review Comment:
Nonblocking since it seems to be consistently hex `002c + version`, but
where are these coming from?
##########
sdks/java/testing/jpms-tests/build.gradle:
##########
@@ -120,7 +121,7 @@ plugins.withType(JavaPlugin).configureEach{
// JPMS requires JDK > 8
project.tasks.each {
it.onlyIf {
- project.hasProperty("compileAndRunTestsWithJava17")
+ project.hasProperty('testJavaVersion')
Review Comment:
Looks like this was just running on 17 previously - do we need tighter
filtering here to avoid running on 11?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
