robertwb commented on code in PR #28657: URL: https://github.com/apache/beam/pull/28657#discussion_r1367220242
########## sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/transforms/providers/JavaRowUdfTest.java: ########## Review Comment: Creating a full jar seemed a bit out-of-scope for a unit test (and that's not where the complexity was). IMHO that could wait until we have the integration testing framework. As for using name for Python, this is essentially the equivalent to "callable" where you can pass a fully-qualified python name (as functions and classes are first class objects in Python, unlike Java). (Also, in Java, even if the file is specified, one still needs the fully qualified name.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
