Abacn commented on code in PR #28621: URL: https://github.com/apache/beam/pull/28621#discussion_r1368990729
########## CHANGES.md: ########## @@ -72,6 +72,8 @@ should handle this. ([#25252](https://github.com/apache/beam/issues/25252)). ## Breaking Changes +* `upload_graph` is not needed since the graph now is uploaded automatically when it is larger than 10MB for Java SDK ([PR#28621](https://github.com/apache/beam/pull/28621). Review Comment: This does not sound like a `breaking change` instead of an improvement, i.e., in which scenario this would break existing user? If so, consider phrasing like: `upload_graph` experiments option is no longer required in the case of large pipeline graphs ... ########## runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java: ########## @@ -256,6 +256,22 @@ private Pipeline buildDataflowPipeline(DataflowPipelineOptions options) { return p; } + private Pipeline buildDataflowPipelineWithLargeGraph(DataflowPipelineOptions options) { Review Comment: minor: this method and the previous one (buildDataflowPipeline) could be static -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
