AnandInguva commented on code in PR #29122:
URL: https://github.com/apache/beam/pull/29122#discussion_r1370957683
##########
sdks/python/apache_beam/runners/worker/sdk_worker.py:
##########
@@ -583,11 +583,12 @@ def _schedule_periodic_shutdown(self):
# type: () -> None
def shutdown_inactive_bundle_processors():
# type: () -> None
- for descriptor_id, last_access_time in self.last_access_times.items():
- if (time.time() - last_access_time >
- DEFAULT_BUNDLE_PROCESSOR_CACHE_SHUTDOWN_THRESHOLD_S):
- BundleProcessorCache._shutdown_cached_bundle_processors(
- self.cached_bundle_processors[descriptor_id])
+ with self._lock:
Review Comment:
@lrakla ah sorry. I wasn't aware this is your first contribution. I am not
sure on how to reproduce the error yet but I can try it on my local and let you
know of any results and the right place to add test(if we could reproduce it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
