volatilemolotov commented on code in PR #29138:
URL: https://github.com/apache/beam/pull/29138#discussion_r1372346879
##########
.github/workflows/beam_Metrics_Report.yml:
##########
@@ -90,11 +90,13 @@ jobs:
name: Metrics Report
path: "${{ github.workspace
}}/.test-infra/jenkins/metrics_report/beam-metrics_report.html"
- name: Generate Date
+ if: always()
Review Comment:
Why do we want to always send the result for this workflow, think its better
to leave this one fail in background and fix it if needed because we would not
like to spam dev with some incomplete result.
Also we have to plan for changing the action parameters to really send out
to dev instead to danny and me. Perhaps this PR can handle that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
