jto commented on code in PR #28944:
URL: https://github.com/apache/beam/pull/28944#discussion_r1373376720
##########
runners/flink/src/test/java/org/apache/beam/runners/flink/ReadSourcePortableTest.java:
##########
@@ -98,6 +100,10 @@ public static void tearDown() throws InterruptedException {
}
@Test(timeout = 120_000)
+ // This test is weird. It makes no sense to test an Unbounded source in
Batch mode
+ // And in streaming mode, an Unbouded source will never stop, which
effectively prevents the test
+ // from ever finishing.
+ @Ignore
Review Comment:
I don't understand this test.
In batch mode and using the `DataStream` API, Flink will complain about
running an Unbounded source and fail immediately (it won't even start the
execution) which makes sense to me.
In streaming mode, the execution never ends and the test is just blocked,
which also makes perfect sense to me.
What are we testing here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
