damccorm commented on code in PR #29148:
URL: https://github.com/apache/beam/pull/29148#discussion_r1373482026
##########
sdks/python/apache_beam/typehints/native_type_compatibility_test.py:
##########
@@ -122,20 +129,22 @@ def test_convert_to_beam_type(self):
def test_convert_to_beam_type_with_builtin_types(self):
if sys.version_info >= (3, 9):
- test_cases = [('builtin dict', dict[str, int], typehints.Dict[str, int]),
- ('builtin list', list[str], typehints.List[str]),
- ('builtin tuple', tuple[str], typehints.Tuple[str]),
- ('builtin set', set[str], typehints.Set[str]),
- (
- 'nested builtin',
- dict[str, list[tuple[float]]],
- typehints.Dict[str,
-
typehints.List[typehints.Tuple[float]]]),
- (
- 'builtin nested tuple',
- tuple[str, list],
- typehints.Tuple[str, typehints.List[typehints.Any]],
- )]
+ test_cases = [
+ ('builtin dict', dict[str, int], typehints.Dict[str, int]),
+ ('builtin list', list[str], typehints.List[str]),
+ ('builtin tuple', tuple[str],
+ typehints.Tuple[str]), ('builtin set', set[str],
typehints.Set[str]),
Review Comment:
Nit: weird spacing here
```suggestion
('builtin tuple', tuple[str], typehints.Tuple[str]),
('builtin set', set[str], typehints.Set[str]),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
