damccorm commented on code in PR #29151:
URL: https://github.com/apache/beam/pull/29151#discussion_r1373717434
##########
.test-infra/metrics/sync/github/sync_workflows.py:
##########
@@ -55,6 +55,26 @@ def __init__(self, id, name, filename):
self.filename = filename
self.runs = []
+def get_dashboard_category(workflow_name):
Review Comment:
;tldr - I agree we'll probably need improvements, though I'm not sure which
ones make sense yet. I'd like to see how it looks now to make a smarter
decision, so my vote would be to merge and iterate.
> this is generally good though for cross-lang it is subtle, e.g.
"PythonUsingJava". We can always come back latter.
Agreed - I thought about adding that and decided to leave it for now. I
think we'll have a much clearer picture of what further breakdowns are needed
once we have this view.
> What's your opinion of keep current structure (used in workflow MDs for
GHA or Jenkins) that is having PreCommit PostCommit LoadTest PerformanceTest
Others
I'm interested in doing something like this, but not sure we should yet; I
tend to think people looking at this dashboard will be one of the following:
1) Someone looking for an individual test (I think this meets that need)
2) Someone looking for systematic patterns in an area.
For (2), I think this meets the need, but I'm not sure. Once we have the
split (and have verified it's reasonable) I'd like to gather feedback from the
community
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
