m-trieu commented on code in PR #29156: URL: https://github.com/apache/beam/pull/29156#discussion_r1375072940
########## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/streams/grpc/GrpcWindmillServer.java: ########## @@ -0,0 +1,358 @@ +/* Review Comment: was able to do this by splitting up the commits 1. to move 2. to add the changes to use GrpcDispatcherClient and GrpcWindmillStreamFactory i think before it treated as a new file because there was a lot of new changes (lines added/deleted) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
