je-ik commented on PR #29162:
URL: https://github.com/apache/beam/pull/29162#issuecomment-1785373963
@aromanenko-dev I think I have the complete understanding. The condition in
the assignment was wrong (don't have any clue how it was reasoned), the problem
is that it was hidden, because until there was at least one call to `add` to
the accumulator (which is nearly always the case), the timestamp was
overwritten.
The bug manifested itself under the following conditions:
a) Combine.withHotKeyFanout, because that merges accumulators without any
elements being added (in the postHotFanoutCombine phase)
b) TimestampCombiner.EARLIEST, because that can create accumulator
timestamps of `BoundedWindow.TIMESTAMP_MIN_VALUE`.
Both conditions are satisfied in the case of query 3 in TPC-DS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
