johannaojeling commented on PR #29184: URL: https://github.com/apache/beam/pull/29184#issuecomment-1786608151
> Go changes looks fine to me and _the rest _as well__. I noticed the different package name for example_test.go but I don't have strong opinion on that. In fact that makes sense to separate out the test functions. Thanks for reviewing! Regarding the `<package>_test` name, it is the convention for writing [testable examples](https://go.dev/blog/examples) to show up as code examples in the go doc (the user should be guided to use `natsio.Write` rather than `Write`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
