tvalentyn commented on code in PR #28781:
URL: https://github.com/apache/beam/pull/28781#discussion_r1378022556
##########
sdks/python/apache_beam/runners/worker/sdk_worker_main.py:
##########
@@ -239,24 +241,29 @@ def _parse_pipeline_options(options_json):
return PipelineOptions.from_dictionary(_load_pipeline_options(options_json))
-def _get_state_cache_size(experiments):
- """Defines the upper number of state items to cache.
-
- Note: state_cache_size is an experimental flag and might not be available in
- future releases.
+def _get_state_cache_size_bytes(options):
+ """Return the maximum size of state cache in bytes.
Returns:
- an int indicating the maximum number of megabytes to cache.
+ an int indicating the maximum number of bytes to cache.
Default is 100 MB
Review Comment:
remove the default comment so that we don't have to sync comments with the
code in multiple places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
