y1chi commented on code in PR #29230:
URL: https://github.com/apache/beam/pull/29230#discussion_r1378212715
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/io/WriteFilesTest.java:
##########
@@ -477,6 +480,39 @@ public void testBuildWrite() {
assertThat(write.getComputeNumShards(), equalTo(originalSharding));
}
+ @Test
+ public void testWriteTransformName() {
Review Comment:
Anywhere in
runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow
we can put these tests, maybe DataflowPipelineTranslatorTest.java? It is very
specific for dataflow that I don't feel like it is good idea to put it under
sdk.
Also can we create a github issue as a TODO for the tests for a more generic
solution for identifying these transforms when submitting to dataflow via v1b3
API. We should remove these tests after we have a more safe solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
