damccorm commented on code in PR #29175:
URL: https://github.com/apache/beam/pull/29175#discussion_r1378888012
##########
sdks/python/apache_beam/transforms/util.py:
##########
@@ -712,10 +824,20 @@ def __init__(
clock=clock,
record_metrics=record_metrics)
self._element_size_fn = element_size_fn
+ self._max_batch_dur = max_batch_duration_secs
+ self._clock = clock
def expand(self, pcoll):
if getattr(pcoll.pipeline.runner, 'is_streaming', False):
raise NotImplementedError("Requires stateful processing (BEAM-2687)")
+ elif self._max_batch_dur is not None:
+ coder = coders.registry.get_coder(pcoll)
+ return pcoll | WithKeys(0) | ParDo(
Review Comment:
Oh I missed that (or forgot), hopefully I wasn't against it initially?
Regardless, I like having this as our first pass, we can see how it performs
and go from there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
