riteshghorse commented on code in PR #29223:
URL: https://github.com/apache/beam/pull/29223#discussion_r1378982942
##########
sdks/python/apache_beam/ml/inference/huggingface_inference.py:
##########
@@ -659,7 +666,7 @@ def _deduplicate_device_value(self, device: str):
"but GPUs are not available. Switching to CPU.")
self._load_pipeline_args['device'] = 'cpu'
else:
- if device:
+ if current_device:
_LOGGER.warning(
Review Comment:
makes sense
##########
sdks/python/apache_beam/ml/inference/huggingface_inference.py:
##########
@@ -647,8 +647,15 @@ def __init__(
_validate_constructor_args_hf_pipeline(self._task, self._model)
def _deduplicate_device_value(self, device: str):
+ current_device = device.upper() if device else None
if 'device' not in self._load_pipeline_args:
- if device == 'CPU':
+ if (not current_device and current_device != 'CPU' and
Review Comment:
urgh.. missed that..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
