damccorm commented on code in PR #29270: URL: https://github.com/apache/beam/pull/29270#discussion_r1380648891
########## .test-infra/metrics/sync/github/sync_workflows.py: ########## @@ -47,6 +47,330 @@ GH_NUMBER_OF_WORKFLOW_RUNS_TO_FETCH =\ os.environ['GH_NUMBER_OF_WORKFLOW_RUNS_TO_FETCH'] +# Maps workflows to dashboard category. Any workflows not in one of these lists +# will get auto-mapped to misc. +CORE_JAVA_TESTS = [ + 'PreCommit SQL Java17', Review Comment: > Or, can we parse the categories from https://github.com/apache/beam/blob/master/.github/workflows/README.md#workflows ? > > My main concern was add another place to maintain the category. Since change naming is more difficult to do, README.md seems to be a good source-of-truth. This would require checking out the beam repo in the cloud function and it starts to get a little ugly (plus potentially exceeds the timeout, though I think its configurable). > Or, let's keep the current inferred category logic and use this list to overwrite the category, instead of expecting every test to have a explicit category. In this way, it may need specify "CORE_INFRA", but most tests in Spark / Flink / Load Test / Performance Test categories can be inferred. I think its a good idea, added fallback logic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
