Abacn commented on code in PR #29276:
URL: https://github.com/apache/beam/pull/29276#discussion_r1381803715
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -486,8 +486,11 @@
* <h3>Upserts and deletes</h3>
*
* The connector also supports streaming row updates to BigQuery, with the
following qualifications:
- * - The CREATE_IF_NEEDED CreateDisposition is not supported. Tables must be
precreated with primary
- * keys. - Only the STORAGE_WRITE_API_AT_LEAST_ONCE method is supported.
+ *
+ * <p>- If the table is not previously created and CREATE_IF_NEEDED is used, a
primary key must be
+ * specified using {@link Write#withPrimaryKey}.
+ *
+ * <p>- Only the STORAGE_WRITE_API_AT_LEAST_ONCE method is supported.
Review Comment:
It appears to me the second point is a more generic guideline, then consider
switch the order of two points?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
