niv-lac opened a new pull request, #29302: URL: https://github.com/apache/beam/pull/29302
This PR is to address inability to utilize SSL, as referenced in issue [21223](https://github.com/apache/beam/issues/21223), by surfacing the cluster builder [withSSL( SSLOptions sslOptions)](https://docs.datastax.com/en/drivers/java/3.11/com/datastax/driver/core/Cluster.Builder.html#withSSL-com.datastax.driver.core.SSLOptions-) method to allow the user to provide SSL configuration. I chose to allow the user to provide SSLOptions to allow different SSL strategies in cases where one user may want client to node encryption and client certificate authentication while another may just want client to node encryption. Notes: - First time creating a PR for a non-work related project. Tried to follow the contribution documentation but please let me know if I need to include anything additional or if there are any processes I missed. Thanks. - Since this PR is surfacing builder ssl functionality from the Datastax driver, I didn't include unit tests to test their functionality. - Also, I don't believe I would be able to configure SSL on the embedded test cluster. - These changes have been tested with poc Dataflow job created via Dataflow classic template where truststore cert (self-signed) and password are retrieved at runtime and used to create an SSLContext which is then used to create SSLOptions. The pipeline reads from SQL Server and writes to a DSE 6.8 Cassandra cluster with SSL (TLS protocol) enabled, hosted in GCP. Please let me know if you have any questions. Thank you. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
