lostluck opened a new pull request, #29306:
URL: https://github.com/apache/beam/pull/29306
Add robust fusion heuristics to Prism's graph Pre-processing, leading to
improved performance when it's enabled. In this PR it's enabled by default, but
in a subsequent PR, it'll be enabled by default in the stand alone command, and
generally all variants except the "test" variant.
* Largely cribbed from Python fn_api_runner/translations.py, which is based
on two main heuristics: Avoiding side input conflicts, and indicating
situations where a producing transform must not be fused with a consuming
transform.
* Updated handlers and fact computation to use return structs.
* Add simple benchmarks for the Go Direct Runner, and Prism to demonstrate
fusion was effective.
* Clean up no-longer necessary exec side override for environments (handled
in handlers now).
* Fix Bug in ProcessBundle handling where a stage without data outputs would
not send progress or split requests. This broke the channel splitting test in
particular.
* As a bonus, this moves that async processing into the progress handling
loop, cleaning up that handling.
Minor fixes:
* Fix Transform UniqueName for Combine extract output.
* Fix channel splitting separation harness test to have an explicit
Reshuffle, as it can't be automatically added for that synthetic test.
* Reduce wait time for separation harness polling.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
