m-trieu commented on code in PR #28835: URL: https://github.com/apache/beam/pull/28835#discussion_r1386164445
########## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/budget/EvenGetWorkBudgetDistributor.java: ########## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.dataflow.worker.windmill.work.budget; + +import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.ImmutableMap.toImmutableMap; + +import java.util.Map.Entry; +import java.util.function.Function; +import java.util.function.Supplier; +import org.apache.beam.runners.dataflow.worker.windmill.WindmillStreamSender; +import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.ImmutableCollection; +import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.ImmutableMap; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** Evenly distributes the provided budget across the available {@link WindmillStreamSender}(s). */ +public final class EvenGetWorkBudgetDistributor implements GetWorkBudgetDistributor { + private static final Logger LOG = LoggerFactory.getLogger(EvenGetWorkBudgetDistributor.class); + private final Supplier<GetWorkBudget> activeWorkBudgetSupplier; + + public EvenGetWorkBudgetDistributor(Supplier<GetWorkBudget> activeWorkBudgetSupplier) { + this.activeWorkBudgetSupplier = activeWorkBudgetSupplier; + } + + @Override + public void distributeBudget( + ImmutableCollection<WindmillStreamSender> streams, GetWorkBudget getWorkBudget) { + if (streams.isEmpty()) { + LOG.warn("Cannot distribute budget to no streams."); + return; + } + + if (getWorkBudget.equals(GetWorkBudget.noBudget())) { + LOG.warn("Cannot distribute 0 budget."); + return; + } + + ImmutableMap<WindmillStreamSender, GetWorkBudget> desiredBudgets = + computeDesiredBudgets(streams, getWorkBudget); + + for (Entry<WindmillStreamSender, GetWorkBudget> streamAndDesiredBudget : + desiredBudgets.entrySet()) { + WindmillStreamSender stream = streamAndDesiredBudget.getKey(); + GetWorkBudget desired = streamAndDesiredBudget.getValue(); + GetWorkBudget remaining = stream.remainingGetWorkBudget(); + // Increase budget when it drops below 50% of the target. + if (remaining.isLessThanFiftyPercentOf(desired)) { + long itemAdjustment = desired.items() - remaining.items(); + long byteAdjustment = desired.bytes() - remaining.bytes(); + + LOG.info( + "Adjusting budget for stream={} by items={} and bytes{}", + stream, + itemAdjustment, + byteAdjustment); + + stream.adjustBudget(itemAdjustment, byteAdjustment); + } + } + } + + private ImmutableMap<WindmillStreamSender, GetWorkBudget> computeDesiredBudgets( + ImmutableCollection<WindmillStreamSender> streams, GetWorkBudget totalGetWorkBudget) { + GetWorkBudget activeWorkBudget = activeWorkBudgetSupplier.get(); + LOG.info("Current active work budget: {}", activeWorkBudget); + GetWorkBudget budgetPerStream = + GetWorkBudget.builder() + .setItems( + divideAndRoundUp( + totalGetWorkBudget.items() - activeWorkBudget.items(), streams.size())) + .setBytes( + divideAndRoundUp( + totalGetWorkBudget.bytes() - activeWorkBudget.bytes(), streams.size())) + .build(); + LOG.info("Desired budgets per stream: {}; stream count: {}", budgetPerStream, streams.size()); + return streams.stream().collect(toImmutableMap(Function.identity(), unused -> budgetPerStream)); + } + + private long divideAndRoundUp(long n, int denominator) { + return (long) Math.ceil(n / (denominator * 1.0)); Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
