liferoad commented on code in PR #29347:
URL: https://github.com/apache/beam/pull/29347#discussion_r1387021290
##########
sdks/python/apache_beam/runners/dataflow/internal/apiclient.py:
##########
@@ -506,12 +508,16 @@ def __init__(self, options, root_staging_location=None):
get_credentials=(not self.google_cloud_options.no_auth),
http=http_client,
response_encoding=get_response_encoding())
- self._storage_client = storage.StorageV1(
- url='https://www.googleapis.com/storage/v1',
- credentials=credentials,
- get_credentials=(not self.google_cloud_options.no_auth),
- http=http_client,
- response_encoding=get_response_encoding())
+ if storage_credentials:
Review Comment:
can we somehow add some comments to capture the discussions about the
project option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
