damondouglas commented on code in PR #29303:
URL: https://github.com/apache/beam/pull/29303#discussion_r1387126801
##########
sdks/python/setup.py:
##########
@@ -338,6 +338,9 @@ def get_portability_package_data():
'testcontainers[mysql]>=3.0.3,<4.0.0',
'cryptography>=41.0.2',
'hypothesis>5.0.0,<=7.0.0',
+ # Used for integration tests against APIs defined, implemented
+ # and deployed in .test-infra/mock-apis
+ f"mock-apis @ file://{os.path.abspath(os.path.join('..', '..',
'.test-infra', 'mock-apis', 'src', 'main', 'python'))}",
Review Comment:
Yes, which is why I added it to `extras_require.test` so that in order to
install, one has to `pip install ".[test]"`. Being a new thing for me, I tested
the difference between `pip install .` and `pip install ".[test]"` in a clean
environment.
Using `pip install .` resulted in `Building wheels for collected packages:
apache-beam, crcmod, dill, hdfs, pyjsparser, docopt`
Using `pip install ".[test]"` resulted in `Building wheels for collected
packages: crcmod, dill, hdfs, apache-beam, mock-apis, pyjsparser, docopt`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
