AnandInguva commented on code in PR #28385:
URL: https://github.com/apache/beam/pull/28385#discussion_r1388177891


##########
sdks/python/apache_beam/io/gcp/bigquery_test.py:
##########
@@ -93,6 +92,42 @@
 
 _LOGGER = logging.getLogger(__name__)
 
+_ELEMENTS = [
+    {
+        'name': 'beam', 'language': 'py'
+    },
+    {
+        'name': 'beam', 'language': 'java'
+    },
+    {
+        'name': 'beam', 'language': 'go'
+    },
+    {
+        'name': 'flink', 'language': 'java'
+    },
+    {
+        'name': 'flink', 'language': 'scala'
+    },
+    {
+        'name': 'spark', 'language': 'scala'
+    },
+    {
+        'name': 'spark', 'language': 'py'
+    },
+    {

Review Comment:
   
https://github.com/apache/beam/blob/5284773c364ab5f54f75fa086313a946411641b8/sdks/python/apache_beam/io/gcp/bigquery_file_loads_test.py#L109
   
   it is the same as the above variable. It is defined here because when using 
pytest with `--import-mode=importlib`, the test modules are not importable by 
each other hence we defined the same variable statically here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to