chamikaramj commented on code in PR #29362: URL: https://github.com/apache/beam/pull/29362#discussion_r1389956209
########## sdks/java/io/kafka/upgrade/src/main/java/org/apache/beam/sdk/io/kafka/upgrade/KafkaIOTranslation.java: ########## @@ -0,0 +1,578 @@ +/* Review Comment: So all we do here is building a Row object from the transform object and vice versa using utilities available in the Beam Schema library. The rest of the boilerplate here is mostly error/null checks which cannot be refactored away easily. We do have fromByteArray/toByteArray methods here to convert objects that do not have a Schema defined (for example, user specified functions) but these are pretty small and different classes can choose to do the serialization in different ways. Do you have a specific refactoring in mind to simplify this code ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
