riteshghorse commented on code in PR #29421: URL: https://github.com/apache/beam/pull/29421#discussion_r1391737838
########## sdks/python/apache_beam/io/requestresponseio_it_test.py: ########## @@ -0,0 +1,168 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +import base64 +import sys +import unittest +from dataclasses import dataclass +from typing import Tuple +from typing import Union + +import urllib3 + +from apache_beam.io.requestresponseio import Caller +from apache_beam.io.requestresponseio import UserCodeExecutionException +from apache_beam.io.requestresponseio import UserCodeQuotaException +from apache_beam.options.pipeline_options import PipelineOptions + +_HTTP_PATH = "/v1/echo" +_PAYLOAD = base64.b64encode(bytes('payload', 'utf-8')) + + +class EchoITOptions(PipelineOptions): + """Shared options for running integration tests on a deployed + ``EchoServiceGrpc`` See https://github.com/apache/beam/tree/master/.test + -infra/mock-apis#integration for details on how to acquire values + required by ``EchoITOptions``. + """ + @classmethod + def _add_argparse_args(cls, parser) -> None: + parser.add_argument( + '--httpEndpointAddress', + required=True, + dest='http_endpoint_address', + help='The HTTP address of the Echo API endpoint; must being with ' + 'http(s)://') + parser.add_argument( + '--neverExceedQuotaId', + default='echo-should-never-exceed-quota', + dest='never_exceed_quota_id', + help='The ID for an allocated quota that should never exceed.') + parser.add_argument( + '--shouldExceedQuotaId', + default='echo-should-exceed-quota', + dest='should_exceed_quota_id', + help='The ID for an allocated quota that should exceed.') + + +# TODO(riteshghorse,damondouglas) replace Echo(Request|Response) with proto +# generated classes from .test-infra/mock-apis: +@dataclass +class EchoRequest: + id: str + payload: bytes + + +@dataclass +class EchoResponse: + id: str + payload: bytes + + +class EchoHTTPCaller(Caller): + """Implements ``Caller`` to call the ``EchoServiceGrpc``'s HTTP handler. + The purpose of ``EchoHTTPCaller`` is to support integration tests. + """ + def __init__(self, url: str): + self.url = url + _HTTP_PATH + + def call(self, request: EchoRequest) -> EchoResponse: + """Overrides ``Caller``'s call method invoking the + ``EchoServiceGrpc``'s HTTP handler with an ``EchoRequest``, returning + either a successful ``EchoResponse`` or throwing either a + ``UserCodeExecutionException``, ``UserCodeTimeoutException``, + or a ``UserCodeQuotaException``. + """ + + try: + resp = urllib3.request( + "POST", + self.url, + json={ + "id": request.id, "payload": str(request.payload, 'utf-8') + }, + retries=False) + + if resp.status < 300: + resp_body = resp.json() + resp_id = resp_body['id'] + payload = resp_body['payload'] + return EchoResponse(id=resp_id, payload=bytes(payload, 'utf-8')) + + if resp.status == 429: # Too Many Requests + raise UserCodeQuotaException(resp.reason) + + raise UserCodeExecutionException(resp.reason) + + except urllib3.exceptions.HTTPError as e: + raise UserCodeExecutionException(e) + + +class EchoHTTPCallerTestIT(unittest.TestCase): + options: Union[EchoITOptions, None] = None + client: Union[EchoHTTPCaller, None] = None + + @classmethod + def setUpClass(cls) -> None: + cls.options = EchoITOptions() Review Comment: since `httpEndpointAddress` is a required argument, this will throw error. This is causing a lot of test suites to fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
