gabrywu commented on PR #29100: URL: https://github.com/apache/beam/pull/29100#issuecomment-1809724264
> Thanks. The only caveat I could imagine is that this would break existing users using `SerializableFunction<TopicPartition, Boolean>` to `setCheckStopReadingFn`. It would be nice that setCheckStopReadingFn could still accept ordinary SerializableFunction > > also aware that there is no guarantee that tearDown will be called after a DoFn is done according to DoFnLifeCycle can you give more details of this case? I find that parts of codes within tearDown run actually. Why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
