johnjcasey commented on code in PR #29443:
URL: https://github.com/apache/beam/pull/29443#discussion_r1395909752
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaDoFn.java:
##########
@@ -203,6 +205,8 @@ private ReadFromKafkaDoFn(ReadSourceDescriptors<K, V>
transform) {
@VisibleForTesting final DeserializerProvider<K> keyDeserializerProvider;
@VisibleForTesting final DeserializerProvider<V> valueDeserializerProvider;
@VisibleForTesting final Map<String, Object> consumerConfig;
+ @VisibleForTesting static final String METRIC_NAMESPACE = "KafkaIOReader";
+ @VisibleForTesting static final String RAW_SIZE_METRIC_PREFIX = "rawSize/";
Review Comment:
we shouldn't duplicate constant Strings like this. We can import them from
KafkaUnboundedReader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
